Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update exception's parent #535

Merged
merged 3 commits into from
Mar 13, 2024
Merged

refactor: Update exception's parent #535

merged 3 commits into from
Mar 13, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Mar 8, 2024 •
edited
Loading

  • Move these exceptions to PhpPact\Consumer\Driver\Exception\
    • InteractionBodyNotAddedException
    • PartNotAddedException
    • MessageContentsNotAddedException
    • PactFileNotWroteException
  • Change parent to ConsumerException
    • BinaryFileNotExistException
    • BinaryFileReadException
    • BodyNotSupportedException
    • MockServerNotStartedException
    • MockServerNotWrotePactFileException
  • Add new parent exceptions:
    • PluginException
    • StubServerException

There is only one exception I don't touch: PhpPact\Standalone\Exception\MissingEnvVariableException. It's from <= v9

JP-Ellis
JP-Ellis approved these changes Mar 13, 2024
View reviewed changes
Copy link

@JP-Ellis JP-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only observation is some ungrammatical English:

  • PactFileNotWroteException should be PactFileNotWrittenException
  • MockServerNotWrotePactFileException should be MockServerPactFileNotWrittenException

Up to you whether it is something to change now, or later.

@tienvx
Copy link
Contributor Author

tienvx commented Mar 13, 2024

I updated them. Thanks for suggestion.

@tienvx tienvx merged commit f22d068 into pact-foundation:ffi Mar 13, 2024
26 checks passed
@tienvx tienvx deleted the update-exception-parent branch March 13, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@Lewiscowles1986 Lewiscowles1986 Awaiting requested review from Lewiscowles1986

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @JP-Ellis