Use Rust FFI #3.4: Make tag optional #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2023
tienvx
force-pushed
the
use-rust-ffi-make-tag-optional
branch
from
c9f2d3a
to
01b069c
Compare
tienvx
commented
Mar 6, 2023
Comment on lines
-76
to
-77
| } elseif (!($tag = \getenv('PACT_CONSUMER_TAG'))) { | ||
| print 'PACT_CONSUMER_TAG environment variable was not set. Skipping PACT file upload.'; |
There was a problem hiding this comment.
I think tag is not required for pact-broker publish command. See #280 (comment)
tienvx
commented
Mar 6, 2023
| @@ -95,7 +95,6 @@ public function endTestSuite(TestSuite $suite): void | |||
| } | |||
|
|
|||
| $broker = new Broker($brokerConfig); | |||
| $broker->createVersionTag(); | |||
There was a problem hiding this comment.
Removed because:
- Tag will be created by
$broker->publish();line below if provided. - If the the version of consumer didn't exist in Pact Broker before, this line will cause this error:
Could not create tag. Version [VERSION_HERE] of [CONSUMER_NAME_HERE] does not exist.
|
Close because it conflict with #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on #280