-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Rust FFI #210
feat: Use Rust FFI #210
Conversation
8340058
to
1561833
Compare
Something wrong with the CI:
|
Wow, moving to Rust is huge! How can I assist as I see the CI is not passing. |
Still problems in my comment above. I think CI is cached so it always run against EDIT: I didn't know Github Actions has this workflow approval feature. |
e9f948d
to
16d8484
Compare
(I've just hit approve @tienvx to run your build) |
@cfmack I fixed the conflict, please take a look again |
7adc919
to
aefbaba
Compare
Your merge commit has syntax error ce65785. I re-based and forced push anyway. New code support specification v4.0 . Tests will not be passed until version 0.1.3 of FFI library is released. But the code is ready to be reviewed. Question: Do we need a new branch 8.x on this repository? |
Updated Pact FFI library to 0.1.3 . Tests will be passed when approve. |
e7f1568
to
02fcbec
Compare
eb47722
to
2dc1b6a
Compare
@cfmack In case you haven't seen this comment on Slack yet https://pact-foundation.slack.com/archives/C9W94PXPY/p1646321219144749 |
Closed as split into smaller pull requests. |
No description provided.