Skip to content

Commit

Permalink
refactor: Use PHP 8.0 constructor property promotion feature
Browse files Browse the repository at this point in the history
  • Loading branch information
tienvx committed Sep 24, 2024
1 parent ac15e32 commit cad1a9e
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 36 deletions.
5 changes: 1 addition & 4 deletions example/binary/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function getImageContent(): string
Expand Down
5 changes: 1 addition & 4 deletions example/csv/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function getReport(): array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function sendRequest(): ResponseInterface
Expand Down
5 changes: 1 addition & 4 deletions example/graphql/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function query(): string
Expand Down
5 changes: 1 addition & 4 deletions example/json/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

/**
Expand Down
5 changes: 1 addition & 4 deletions example/matchers/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function sendRequest(): ResponseInterface
Expand Down
5 changes: 1 addition & 4 deletions example/multipart/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function updateUserProfile(): string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function getResults(): array
Expand Down
5 changes: 1 addition & 4 deletions example/xml/consumer/src/Service/HttpClientService.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@ class HttpClientService
{
private Client $httpClient;

private string $baseUri;

public function __construct(string $baseUri)
public function __construct(private string $baseUri)
{
$this->httpClient = new Client();
$this->baseUri = $baseUri;
}

public function getMovies(): string
Expand Down

0 comments on commit cad1a9e

Please sign in to comment.