Fix/generators non json bodies - rebased #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
the downloaded release tarball (downloaded by `node-pre-gyp install --fallback-to-build=false`) contains files in the `native` folder, so we need to reset them to whatever comes from git before building otherwise we might end up using the file from the downloaded archive and not from the change in the PR this use to work for changes in `index.node.d.ts` because older release tarballs didn't contain that file compare https://github.com/pact-foundation/pact-js/releases/download/v10.0.0-beta.33/node-v72-linux-x64-glibc.tar.gz with https://github.com/pact-foundation/pact-js/releases/download/v10.0.0-beta.34/node-v72-linux-x64-glibc.tar.gz
|
Thanks Artur - I'll look to get these in next week (or maybe this weekend if I get some time). Appreciate all of your help. |
|
LGTM |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #636 but rebased on
feat/v3.0.0and with conflict solved