-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Linting code #584
fix: Linting code #584
Conversation
Hmm. Lint is already run by the build, and lint runs prettier, so if the examples weren't formatted already the build should fail. Probably we have a misconfiguration where the formatter has different settings in checking vs formatting for some reason. |
Looks like linting has been disabled since march in the V3 branch, in 6afc281 . I'm not sure why, but we'll need to re-enable it before merging V3 in. |
in this branch it only ran for |
@@ -7,7 +7,7 @@ | |||
"scripts": { | |||
"build": "npm run build:v2 && npm run build:v3", | |||
"build:v2": "npm run lint && npm run compile", | |||
"build:v3": "neon build --release", | |||
"build:v3": "npm run lint && neon build --release", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'm not sure this is the right place for it either, as neon build
doesn't use anything that would be linted.
I think on master probably the compile
script should move into the dist
script (and be removed), and lint is then a predist
script.
We're really due an overhaul of all these scripts, there are many more than is necessary.
Well spotted. However, since the commit I linked, the |
run
prettier
on the code and enable the lint check in CI