Cannot find module '../native' (when using V3 spec beta release)

[TimothyJones]

Copied from another issue about V3:

---

I'm having similar issue with 10.x as well. But we are not using jest-pact and the error is

    Cannot find module '../native' from 'node_modules/@pact-foundation/pact/v3/index.js'

Originally posted by @aelmekeev in #483 (comment)

[TimothyJones]

@mefellows @uglyog : I encountered this too, and fixed it by modifying the import to ../native/index.node. I don't have the context for the V3 branch though - would that be an appropriate fix? If not, how should we resolve this?

[mefellows]

It may do. My recollection of the issue is that if pact is installed at a different level (e.g. within another dependency or lerna hierarchy) the relative path isn't resolved correctly.

We'll need to reliably reproduce it to fix first.

[TimothyJones]

I think the problem is more to do with node module resolution - index.node isn’t always picked up as a candidate for index. My suspicion is that this might only be a problem for typescript users, because the documentation says that index includes work “the same as node”, but only mention index.js, not index.node

…

Sent from my mobile

On 7 Oct 2020, at 9:36 am, Matt Fellows ***@***.***> wrote:  It may do. My recollection of the issue is that if pact is installed at a different level (e.g. within another dependency or lerna hierarchy) the relative path isn't resolved correctly. We'll need to reliably reproduce it to fix first. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[uglyog]

I've updated the imports, but I haven't been able to replicate this issue. It was worked ok for my test projects.

[uglyog]

Ah! from 'node_modules/@pact-foundation/pact/v3/index.js'
should have been from 'node_modules/@pact-foundation/pact/v3/pact.js'

due to the types and main entry in package.json. This has now been changed to index instead of pact

[aelmekeev]

My recollection of the issue is that if pact is installed at a different level (e.g. within another dependency or lerna hierarchy) the relative path isn't resolved correctly.

This is probably the case cause we are using yarn workspaceses and @pact-foundation is in root level node_modules and not "workspace" level node_modules.

[TimothyJones]

@aelmekeev Does v10.0.0-beta.17 work for you?

[aelmekeev]

@TimothyJones it does work 🎉

[TimothyJones]

Great! It works for jest-pact's beta V3 build too, so I think we can close this.