Fix/enable external https requests #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local proxy currently assumes that a verification will take place against either a) a local endpoint or b) an http endpoint. It did not support external hosts on https.o It also did not rewrite the Host header correctly (see golang/go#28168) This change: 1. Rewrites the header during proxying 2. Hard codes the local proxy to run only on http - there is no reason why it should run on https even if the endpoint under test _is_. 3. Opens the door for client configured transports during verification, to enable self-signed certificates to be easily used
* Adds new `CustomTLSConfig` to Verifier interface * Fixes issue * Adds integration tests
mefellows
force-pushed
the
fix/enable-external-https-requests
branch
from
8a8fdea
to
54d3c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set their own TLS configuration for provider verification, which can be useful in the following situations: