Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to run arbitrary sidecar extraContainers #47

Merged

Conversation

joshuasimon-taulia
Copy link
Contributor

@joshuasimon-taulia joshuasimon-taulia commented Mar 13, 2023

adds the ability to run arbitrary sidecar extraContainers

i have a use case where i need to use cloudsql proxy to connect the pact broker to a google cloudsql postgres instance.

extraContainers:
  - name: cloudsql-proxy
    image: gcr.io/cloudsql-docker/gce-proxy:1.22.0
    command:
      - /cloud_sql_proxy
      - '-instances=my-project:my-zone:my-db-name=tcp:5432'
      - '-enable_iam_login'

another common use cases is running a vault sidecar to inject secrets

test values correctly output a new sidecar

        - command:
          - /cloud_sql_proxy
          - -instances=my-project:my-zone:my-db-name=tcp:5432
          - -enable_iam_login
          image: gcr.io/cloudsql-docker/gce-proxy:1.22.0
          name: cloudsql-proxy

mostly copied from the common pattern at https://github.com/argoproj/argo-helm/blob/c08fc230d75c85b2c9a07138c5c7b7bc957b98df/charts/argo-cd/templates/argocd-repo-server/deployment.yaml

@joshuasimon-taulia
Copy link
Contributor Author

@ChrisJBurns fiddling with PGP to get my commits verified autoclosed and bugged out #46.

@ChrisJBurns
Copy link
Contributor

ChrisJBurns commented Mar 14, 2023

@joshuasimon-taulia Will you be able to rebase your branch with master? When you've done this, we can get this merged in. Also could you update the issue description so it doesn't have the database password issue as this has been fixed with #43

Signed-off-by: joshuasimon-taulia <20404891+joshuasimon-taulia@users.noreply.github.com>
Signed-off-by: joshuasimon-taulia <20404891+joshuasimon-taulia@users.noreply.github.com>
@joshuasimon-taulia
Copy link
Contributor Author

@joshuasimon-taulia Will you be able to rebase your branch with master? When you've done this, we can get this merged in. Also could you update the issue description so it doesn't have the database password issue as this has been fixed with #43

done and confirmed working

@ChrisJBurns ChrisJBurns merged commit 5981831 into pact-foundation:master Mar 14, 2023
@joshuasimon-taulia
Copy link
Contributor Author

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants