Skip to content

Commit

Permalink
Do not invoke setup.py directly
Browse files Browse the repository at this point in the history
- It is not recommended to invoke ``setup.py`` directly, instead opting for ``python -m build`` for the commands in this commit (see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html)
- Add newsfragment for ethereum#70
  • Loading branch information
fselmo committed Nov 22, 2022
1 parent 3ff1c9c commit 7c85f95
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ clean-pyc:
find . -name '__pycache__' -exec rm -rf {} +

lint:
tox -elint
tox -e lint

lint-roll:
isort --recursive <MODULE_NAME> tests
Expand Down Expand Up @@ -83,11 +83,11 @@ release: check-bump clean
git config commit.gpgSign true
bumpversion $(bump)
git push upstream && git push upstream --tags
python setup.py sdist bdist_wheel
python -m build
twine upload dist/*
git config commit.gpgSign "$(CURRENT_SIGN_SETTING)"


dist: clean
python setup.py sdist bdist_wheel
python -m build
ls -l dist
1 change: 1 addition & 0 deletions newsfragments/70.internal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not invoke ``setup.py`` directly. Minor cleanup and refactors in newsfragment ``README.md`` and newsfragment validation. Minot cleanup in ``Makefile``.

0 comments on commit 7c85f95

Please sign in to comment.