-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test GitHub's review functionality.
- Improved v3 support
- Replaced deprecated Hugo syntax
Man, that is the first time that bot has be used. It is ruthless. Haha, I will review this soon. |
Perhaps it would be helpful to show GitLab CI's output to verify
|
On my end everything works except reCAPTCHA. Is there anything special - is it reCAPTCHA v3?
|
Overall speaking, I've not touched your code about reCAPTCHA v3, which I've never tried, so I can't comment. Btw, this PR is meant to be an analogue of mmistakes/minimal-mistakes#1845, and the Go-HTML code in this PR does its work of getting the site config parameters into the generate HTML pages. reCAPTCHA is another issue. |
I see now. I will just need to revert to reCAPTCHA v2. Thanks for all of this. |
👍 for the merge. |
Description
Fix #28 and close #29.
EDIT: Also closes #21 - PC
Types of changes
Checklist:
theme.toml
, accordingly.