fix: setTheme now works correctly when a function is passed. #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #277.
The dependencies of the set-state function, that is a useCallback hook it's self were faulty.
This PR defined 'theme' as a dependency of the callback-hook and removes 'forcedTheme' from the dependency.
Additionally a test-case has been added where setState is called with
(theme) => theme === 'light' ? 'dark' : 'light')
This PR is based on: #285
Commits