Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prune: yarn.lock; docs(website): pnpm; chore: enforce pnpm #39

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

JeromeFitz
Copy link
Contributor

@JeromeFitz JeromeFitz commented Aug 18, 2022

Addition to #18

  • Enforce pnpm at the root install for workspaces
  • Removes old yarn.lock files from the move to pnpm
  • Contributors for localized ./website development for cmdk should use pnpm
    • Separate from the overall README which people can install cmdk via their preferred package manager

Addition to pacocoursey#18
- Contributors are requested to use `pnpm`
@vercel
Copy link

vercel bot commented Aug 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cmdk-website ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 1:06AM (UTC)

@JeromeFitz
Copy link
Contributor Author

JeromeFitz commented Aug 18, 2022

This is really cool (understatement) and congrats on the release (also understatement)! 🚀

If you prefer an issue creation first, I understand. Please let me know if you have any questions or prefer any changes.

▲ cmdk [chore/yarn-removal] yarn install
yarn install v1.22.19
info No lockfile found.
$ npx only-allow pnpm
╔═════════════════════════════════════════════════════════════╗
║                                                             ║
║   Use "pnpm install" for installation in this project.      ║
║                                                             ║
║   If you don't have pnpm, install it via "npm i -g pnpm".   ║
║   For more details, go to https://pnpm.js.org/              ║
║                                                             ║
╚═════════════════════════════════════════════════════════════╝
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@JeromeFitz JeromeFitz changed the title prune: 🔥 yarn.lock; docs: 📝 pnpm (localized) prune: yarn.lock; docs(website): pnpm; chore: enforce pnpm Aug 18, 2022
@pacocoursey pacocoursey merged commit 8477246 into pacocoursey:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants