fix flaky test with HMR console

pacocoursey · Oct 30, 2024 · 74087a6 · 74087a6
1 parent 5d9d6e3
commit 74087a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/test/basic.test.ts b/test/basic.test.ts
@@ -22,8 +22,8 @@ test.describe('basic behavior', async () => {
 
   test('item onSelect is called on click', async ({ page }) => {
     const item = page.locator(`[cmdk-item][data-value="Item"]`)
-    const [message] = await Promise.all([page.waitForEvent('console'), item.click()])
-    expect(message.text()).toEqual('Item selected')
+    await item.click()
+    expect(await page.evaluate(() => (window as any).onSelect)).toEqual('Item selected')
   })
 
   test('first item is selected by default', async ({ page }) => {

diff --git a/test/pages/index.tsx b/test/pages/index.tsx
@@ -7,7 +7,13 @@ const Page = () => {
         <Command.Input placeholder="Search…" className="input" />
         <Command.List className="list">
           <Command.Empty className="empty">No results.</Command.Empty>
-          <Command.Item keywords={['key']} onSelect={() => console.log('Item selected')} className="item">
+          <Command.Item
+            keywords={['key']}
+            onSelect={() => {
+              ;(window as any).onSelect = 'Item selected'
+            }}
+            className="item"
+          >
             Item
           </Command.Item>
           <Command.Item value="xxx" className="item">