handle unattached hardware reservations #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boz
force-pushed
the
fix-unattached-reservation
branch
2 times, most recently
from
fca0284 to
740b7fc
Compare
boz
changed the title
This is currently failing with: ``` TypeError: 'NoneType' object is not subscriptable ``` Signed-off-by: Adam Bozanich <adam.boz@gmail.com>
boz
force-pushed
the
fix-unattached-reservation
branch
from
740b7fc to
8e33d03
Compare
displague
reviewed
Aug 16, 2021
packet/HardwareReservation.py
Outdated
|
|
||
| # not attached | ||
| if data["device"] is None: | ||
| self.attached_to = None |
There was a problem hiding this comment.
Alternatively, we could use except (KeyError, IndexError, TypeError): in the following try block.
There was a problem hiding this comment.
@boz I think I would prefer that approach. The overfit error handling is mildly concerning, but I don't see any risks that are not already present in the previous try block.
There was a problem hiding this comment.
Sure, will do.
I did it that way at first but I felt like it could shadow other problems too easily.
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
fix-unattached-reservation
branch
from
998e810 to
37af084
Compare
displague
approved these changes
Aug 29, 2021
|
Thanks so much @displague - sorry I ran out of bandwidth, was just coming back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently failing with: