-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gotosocial] Pachli application crashes on some specific tabs. #971
Comments
The crash in Conversations appears to be because the server is returning a Conversation with a missing or empty The crash in the Federated tab is probably caused by the Conversation tab crashing. IIRC, in the pager the tabs on either side of the current tab are loaded opportunistically. So you switch to the Federated tab, the Conversation tab is next to it, the Conversations are loaded, and then crash. |
It's possible for some servers to return a conversation that has an empty (or possibly missing) `accounts` property. In the previous code this would crash trying to access an item in an empty list. Fix this by handling the "no participants" case. Fixes #971
Describe the bug
Connected to a GoToSocial instance, when accessing some specific tabs (mentions, private mentions, federated) the application simply closes.
To Reproduce
Steps to reproduce the behavior:
I sent via e-mail credentials to my GoToSocial instance for you to test.
Connect to GtS
Click on Private Message tab
Add more tabs
Click on Federated tab
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots or video
If applicable, please add screenshots or video to help explain your problem.
0768aa990552063a044ca61d6ddfe97c5296452c.mp4
Versions
Android 11
Moto G5 G Plus
Latest version from google play (today)
Affirmation
I have checked other issues for this project (open and closed) and I cannot find one that matches the problem I am reporting.
The text was updated successfully, but these errors were encountered: