Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for letter-spacing and word-spacing css #29

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Account for letter-spacing and word-spacing css #29

merged 1 commit into from
Jan 13, 2017
+3 −1

Conversation

atomiccupcake
Copy link
Contributor

This fixes incorrect wrapping and truncating when the css uses letter-spacing and/or word-spacing properties.

@atomiccupcake
Copy link
Contributor Author

The build failed because GitHub was having server issues this morning.. not sure how to make TravisCI rerun it....

@joelmukuthu
Copy link
Contributor

joelmukuthu commented Jan 13, 2017 •
edited
Loading

Hi, thanks for the PR! I've restarted the build :)

@pablosichert pablosichert merged commit c4880ec into pablosichert:master Jan 13, 2017
pablosichert added a commit that referenced this pull request Jan 25, 2017
@pablosichert
Revert "Account for letter-spacing and word-spacing css (#29)"
cfc73e7 
context.font does not expect letter spacing / word spacing argument.
See #30 for more details.

This reverts commit c4880ec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomiccupcake @joelmukuthu @pablosichert