Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integrity by using existing database #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paazmaya
Copy link
Owner

Might solve #54

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #59 into master will decrease coverage by 7.12%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   98.17%   91.04%   -7.13%     
==========================================
  Files           9       10       +1     
  Lines         164      201      +37     
==========================================
+ Hits          161      183      +22     
- Misses          3       18      +15     
Impacted Files Coverage Δ
lib/find-data.js 17.64% <17.64%> (ø)
lib/process-files.js 95.65% <75.00%> (-4.35%) ⬇️
bin/tozan.js 100.00% <100.00%> (ø)
index.js 96.00% <100.00%> (+1.26%) ⬆️
lib/constants.js 100.00% <100.00%> (ø)
lib/find-files.js 100.00% <100.00%> (ø)
lib/create-database.js 95.23% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e50aef...29feef1. Read the comment docs.

@paazmaya
Copy link
Owner Author

@paazmaya please sign-off your commit and make sure that the unit test coverage does not drop.

paazmaya added 4 commits June 3, 2020 23:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@paazmaya paazmaya force-pushed the 54-check-integrity branch from 5af2dd4 to 29feef1 Compare June 3, 2020 20:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant