Skip to content
This repository has been archived by the owner on Mar 29, 2018. It is now read-only.

Added minBy and maxBy methods #37

Merged
merged 2 commits into from
Nov 6, 2014
Merged

Added minBy and maxBy methods #37

merged 2 commits into from
Nov 6, 2014

Conversation

michaeleisel
Copy link
Contributor

These methods are equivalent to the min_by and max_by methods in Ruby. They are useful for, say, finding the Point with the largest x-value. They've been written for efficiency rather than clarity and conciseness.

@michaeleisel
Copy link
Contributor Author

Or should these methods be in SequenceOf? I don't understand when a method should be in SequenceOf and when it should be in Array.

@pNre
Copy link
Owner

pNre commented Nov 3, 2014

SequenceOf was supposed to contain lazily evaluated methods. So the "rule" is: if something can be done lazily it should (also) be in SequenceOf.
Anyway, thanks for your contribution. I'll test and merge it as soon as I can.

pNre added a commit that referenced this pull request Nov 6, 2014
@pNre pNre merged commit c8d9140 into pNre:master Nov 6, 2014
@michaeleisel
Copy link
Contributor Author

What are some good things to contribute to this repo?

@pNre
Copy link
Owner

pNre commented Nov 7, 2014

Actually, I don't know, if you find there's something missing you'd like to add fell free to do it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants