Skip to content
This repository has been archived by the owner on Mar 29, 2018. It is now read-only.

Result of indexOf, lastIndexOf should be an optional #8

Closed
delebedev opened this issue Jun 16, 2014 · 3 comments
Closed

Result of indexOf, lastIndexOf should be an optional #8

delebedev opened this issue Jun 16, 2014 · 3 comments

Comments

@delebedev
Copy link

returning -1 from these methods seems like a good old hack from C-languages days. Now we have fancy optionals and it suits well here.
What do you think? Pull request is coming.
@pNre
Copy link
Owner

pNre commented Jun 16, 2014

You know, I agree, too much thinking in Javascript.

@delebedev
Copy link
Author

👍 , I'll make PR a bit later

@iluuu1994
Copy link

👍

Completely agree.

@delebedev delebedev mentioned this issue Jun 16, 2014
Merged
pNre added a commit that referenced this issue Jun 16, 2014
@pNre
Merged fix for #8, rewrote lastIndexOf
7907bbe
@pNre pNre closed this as completed Jun 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@delebedev @iluuu1994 @pNre