Filtering #59
Merged
Filtering #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # actionlist/app/components/SideMenu.js
# Conflicts: # actionlist/app/components/SideMenu.js # actionlist/package.json
# Conflicts: # actionlist/app/actions/action_items.js # actionlist/app/actions/types.js # actionlist/app/components/SideMenu.js # actionlist/app/reducers/action_items.js # actionlist/package.json
Nethracs
reviewed
Apr 20, 2017
| onSort: criteria => dispatch(sortActionList(criteria)), | ||
| }); | ||
|
|
||
| /* eslint-enable no-unused-vars */ |
There was a problem hiding this comment.
Remove this eslint exception
Nethracs
approved these changes
Apr 20, 2017
burnumd
requested changes
Apr 20, 2017
burnumd
requested changes
Apr 20, 2017
|
|
||
| const ContentHeader = ({ title }) => ( | ||
| <View> | ||
| <Text style={style.headerText}>{title}</Text> |
There was a problem hiding this comment.
I'd recommend not using a title prop and just use the children prop. It looks like it's allowed for Text components to have node children, so if you just use children you can pass off prop validation to the react-native component and allow yourself more flexibility.
There was a problem hiding this comment.
I tried to use children and lint threw an error saying I need to have a prop validation for it
There was a problem hiding this comment.
Yes, the type of children should be documented as React.PropTypes.node: jsx-eslint/eslint-plugin-react#7
# Conflicts: # actionlist/app/containers/PreferencesContainer.js
burnumd
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 filters implemented. The ones based on list options (documentRouteStatus, documentType and actionRequested)