Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depdencies to latest versions. #506

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update depdencies to latest versions. #506

merged 1 commit into from
Oct 11, 2024

Conversation

smolkaj
Copy link
Member

@smolkaj smolkaj commented Oct 11, 2024

Fixes #505.

Signed-off-by: smolkaj <smolkaj@google.com>
@smolkaj
Copy link
Member Author

smolkaj commented Oct 11, 2024

@chrispsommers, this doesn't do anything interesting other than updating a bunch of dependencies. This is often the easiest way to fix sudden build regressions :)

@chrispsommers
Copy link
Collaborator

Is there any lesson or advice here beyond your comment, which might help posterity?

@smolkaj
Copy link
Member Author

smolkaj commented Oct 11, 2024

The other lesson -- and what very likely triggered this issue -- is that our CI scripts currently use ubuntu-latest, which is a moving target. Specifically, in .github/workflows/ci-build-proto.yml, we currently have:

  build:
    runs-on: ubuntu-latest

And, sure enough, ubuntu-latest was moved from Ubuntu22.04 to Ubuntu 24.04 2 weeks ago: actions/runner-images@ae99c16.

It is typical for this to cause regressions, and it is typical that they can be fixed by simply updating all dependencies to their latest versions.

If we wanted, we could use a stable label such as ubuntu-24.04 instead of the moving label ubuntu-latest to avoid such regression. But I actually think this is a healthy forcing function to prevent bit rod, so would prefer to keep things as is.

@smolkaj
Copy link
Member Author

smolkaj commented Oct 11, 2024

Shall we get this merged, @chrispsommers ?

@chrispsommers chrispsommers merged commit fe85996 into main Oct 11, 2024
6 checks passed
@chrispsommers chrispsommers deleted the update-deps branch October 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf build broken at HEAD
2 participants