[P4fmt]: Add comment printing capability to P4Formatter
#4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
snapdgn
force-pushed
the
print-comments
branch
from
9e35e8a
to
59ff847
Compare
Signed-off-by: Nitish <snapdgnn@proton.me>
|
Is this expected to replace #4845? |
snapdgn
changed the title
P4Formatter to Include Attached Comments in OutputP4Formatter
fruffy
changed the title
P4FormatterP4Formatter
Signed-off-by: Nitish <snapdgnn@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top off #4845(which traverses the AST and builds a side map for storing comments associated with each node). This PR uses that map to retrieve and print comments through the P4Formatter pretty-printer.
Support for new nodes are being added continuously.