Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4fmt]: attaching comments to IR Nodes #4845

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[P4fmt]: attaching comments to IR Nodes #4845

wants to merge 14 commits into from
+200 −7

Commits on Sep 9, 2024

  1. [P4fmt]: attach comments 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    21c7fac View commit details
    Browse the repository at this point in the history

  2. fix: resolve issue with modifying container during iteration 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    64174bf View commit details
    Browse the repository at this point in the history

  3. refactor: rename variables, remove unused headers 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    13ba1f1 View commit details
    Browse the repository at this point in the history

  4. doc comments 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9a10d7d View commit details
    Browse the repository at this point in the history

  5. use node's clone-id 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4924399 View commit details
    Browse the repository at this point in the history

  6. rebase & resolve nits 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    781c810 View commit details
    Browse the repository at this point in the history

  7. expose IHasSourceInfo for the Comment class 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d67ad3c View commit details
    Browse the repository at this point in the history

  8. extract comments from InputSources instead of partial SourceInfo 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    629bab8 View commit details
    Browse the repository at this point in the history

  9. remove extraneous method 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b534708 View commit details
    Browse the repository at this point in the history

  10. fix missing toString() override 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5440d9d View commit details
    Browse the repository at this point in the history

  11. chore: comment fixes & minor refactoring 

    Signed-off-by: Nitish <snapdgnn@proton.me>

Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6413157 View commit details
    Browse the repository at this point in the history

  12. refactor parseProgram fn 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4dfe245 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. resolve: nits & suggestions 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    622d1bd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. switch to Inspector pass 

    Signed-off-by: Nitish <snapdgnn@proton.me>
    @snapdgn
    snapdgn committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    19d55e4 View commit details
    Browse the repository at this point in the history