[P4Testgen] Fix problems with the reachability pass. #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/reachability_pass_fixes
branch
3 times, most recently
from
52dcc02
to
2c33e75
Compare
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/reachability_pass_fixes
branch
from
2c33e75
to
8e03209
Compare
vlstill
reviewed
Jul 30, 2024
Signed-off-by: fruffy <fruffy@nyu.edu>
vlstill
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some issues with the reachability pass and modernize the code. This pass is barely used so the changes are not of much consequence. This fixes are useful for better control-flow analysis and statistics on program complexity. Hoping to contribute some of this code soon.
Also add some more getter/setter helper functions to
callgraph.h.