P4Fmt reference checker #4778
Merged
P4Fmt reference checker #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapdgn
force-pushed
the
reference-checker
branch
3 times, most recently
from
82aeaec
to
5b61bea
Compare
|
Not an immediate requirement, but I think it would be great to integrate this checker with GitHub CIs eventually. For now, adding a section in the README describing its usage might be good enough. |
snapdgn
force-pushed
the
reference-checker
branch
from
0db71ee
to
701a3e3
Compare
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
snapdgn
force-pushed
the
reference-checker
branch
2 times, most recently
from
667f91d
to
2ac1dc7
Compare
Signed-off-by: Nitish <snapdgnn@proton.me>
snapdgn
force-pushed
the
reference-checker
branch
from
2ac1dc7
to
b113a5d
Compare
Signed-off-by: Nitish <snapdgnn@proton.me>
fruffy
requested changes
Jul 5, 2024
Signed-off-by: Nitish <snapdgnn@proton.me>
Signed-off-by: Nitish <snapdgnn@proton.me>
snapdgn
force-pushed
the
reference-checker
branch
from
df82615
to
ee69785
Compare
fruffy
reviewed
Jul 9, 2024
Signed-off-by: Nitish <snapdgnn@proton.me>
fruffy
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference checker for
p4fmtformatter