Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce guard for aarch64 GCC compilation. #4647

Merged
merged 3 commits into from
May 2, 2024
Merged

Introduce guard for aarch64 GCC compilation. #4647

merged 3 commits into from
May 2, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented May 1, 2024

Fixes #4639.

@fruffy fruffy requested a review from jafingerhut May 1, 2024 12:34
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label May 1, 2024
@jafingerhut
Copy link
Contributor

The only way I know to review this in a substantive way is for me to try out this change locally and build on arm64 Ubuntu Linux. I will do that, and approve if things look better.

jafingerhut
jafingerhut approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With these changes, I verified I can build p4c and pass several tests on an Ubuntu 20.04 aarch64 system.

@ChrisDodd
Copy link
Contributor

Should this be done with a check_include_file(mm_malloc.h, HAVE_MM_MALLOC_H) in CMakeLists.txt and #cmakedefine HAVE_MM_MALLOC_H 1 in cmake/config.h.cmake?

@fruffy
Copy link
Collaborator Author

fruffy commented May 1, 2024

Should this be done with a check_include_file(mm_malloc.h, HAVE_MM_MALLOC_H) in CMakeLists.txt and #cmakedefine HAVE_MM_MALLOC_H 1 in cmake/config.h.cmake?

I can add this instead, just a little tricky to test whether it is working right.

@jafingerhut
Copy link
Contributor

I retested this PR locally after it had 2 commits on an Ubuntu 20.04 aarch64 Linux system, and it compiled and tested fine.

@fruffy fruffy added this pull request to the merge queue May 2, 2024
@jafingerhut jafingerhut mentioned this pull request May 2, 2024
Closed
Merged via the queue into main with commit 4d9f6f2 May 2, 2024
16 of 17 checks passed
@fruffy fruffy deleted the fruffy/aarch64 branch May 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include of file mm_malloc.h breaks build for Ubuntu aarch64 systems
3 participants
@fruffy @jafingerhut @ChrisDodd