Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ebpf comment format #4624

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

sumit7754
Copy link
Contributor

I have made the following changes in ebpf(backend):

Used triple slashes (///) for commenting functions and classes.
Used double slashes (//) for comments within the code.

@fruffy
Copy link
Collaborator

fruffy commented Apr 17, 2024

Thanks for doing this! It makes the entire compiler more consistent in style.
Your PR is out-of-sync. You may have to rebase or merge.

@sumit7754
Copy link
Contributor Author

You're welcome @fruffy I'm glad to hear that it's making the compiler more consistent in style. If you have any more feedback then please let me know

@sumit7754 sumit7754 reopened this Apr 17, 2024
@fruffy fruffy added the documentation Topics related to compiler documentation. label Apr 18, 2024
backends/ebpf/target.h Outdated Show resolved Hide resolved
backends/ebpf/target.h Outdated Show resolved Hide resolved
backends/ebpf/target.h Outdated Show resolved Hide resolved
backends/ebpf/target.h Outdated Show resolved Hide resolved
backends/ebpf/runtime/psa.h Outdated Show resolved Hide resolved
backends/ebpf/runtime/pcap_util.h Show resolved Hide resolved
sumit7754 and others added 6 commits April 18, 2024 21:04
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
@sumit7754 sumit7754 requested a review from fruffy April 18, 2024 15:56
Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a bunch of lowercase instances and dots missing but I do not want to be too pedantic.

@fruffy fruffy enabled auto-merge April 18, 2024 16:05
@fruffy fruffy added this pull request to the merge queue Apr 18, 2024
Merged via the queue into p4lang:main with commit 6643d68 Apr 18, 2024
17 checks passed
@sumit7754 sumit7754 deleted the update-ebpf-comment-format branch April 19, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants