Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Commenting Style in the BMv2 Backend. #4603

Merged
merged 36 commits into from
Apr 7, 2024

Conversation

sumit7754
Copy link
Contributor

fixes #4567

I have made the following changes in Bmv2(backend):

Used triple slashes (///) for commenting functions and classes.
Used double slashes (//) for comments within the code.

backends/bmv2/common/controlFlowGraph.h Outdated Show resolved Hide resolved
BlockConverted blockConverted;
//
///
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add something here?

backends/bmv2/common/helpers.h Outdated Show resolved Hide resolved
backends/bmv2/common/helpers.h Outdated Show resolved Hide resolved
backends/bmv2/common/helpers.h Outdated Show resolved Hide resolved
backends/bmv2/common/header.cpp Outdated Show resolved Hide resolved
backends/bmv2/common/header.cpp Outdated Show resolved Hide resolved
backends/bmv2/common/header.h Outdated Show resolved Hide resolved
backends/bmv2/common/header.h Outdated Show resolved Hide resolved
backends/bmv2/common/helpers.h Outdated Show resolved Hide resolved
sumit7754 and others added 22 commits April 7, 2024 05:17
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
sumit7754 and others added 7 commits April 7, 2024 05:35
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
@sumit7754 sumit7754 requested a review from fruffy April 7, 2024 16:21
@fruffy fruffy added this pull request to the merge queue Apr 7, 2024
@fruffy fruffy changed the title Update Commenting Style in Bmv2 Backend Update the Commenting Style in the BMv2 Backend Apr 7, 2024
@fruffy fruffy changed the title Update the Commenting Style in the BMv2 Backend Update the Commenting Style in the BMv2 Backend. Apr 7, 2024
Merged via the queue into p4lang:main with commit ed94813 Apr 7, 2024
17 checks passed
@sumit7754 sumit7754 deleted the update-commenting-bmv2 branch April 8, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format Comments Consistently in P4C.
2 participants