Fix spurious failure when two tests try to remove ptf.log
at the same time.
#4591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that test A deletes
ptf.log
and then test B tries to delete the log a second later. This will cause the following error:To avoid that from happening we make sure the log is saved in the unique temporary directory instead. We already did this for the actual PTF test, but not for the initial PTF check.
Ideally, we would fix this error from occurring at all in PTF.