Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Debian CI test badge in the README. Add Fedora and MacOS CI badge. #4569

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

Abhinavcode13
Copy link
Contributor

The Main build image has been removed for improved readability

Removed the Main build image
@fruffy
Copy link
Collaborator

fruffy commented Mar 27, 2024

I would suggest using the same approach as #4510, which does not remove the main build image but fixes it.

@fruffy fruffy added the documentation Topics related to compiler documentation. label Mar 27, 2024
@fruffy
Copy link
Collaborator

fruffy commented Mar 27, 2024

Looks good, please change the title of this pull request to more accurately reflect the content changes. It also helps to update your description.

@Abhinavcode13 Abhinavcode13 changed the title Minor Fixes #4510 Updated main build badge for better readability Mar 27, 2024
@Abhinavcode13
Copy link
Contributor Author

Sure @fruffy , LGTM now.

@fruffy fruffy changed the title Updated main build badge for better readability Fix broken Debian build badge in the README. Mar 27, 2024
@fruffy fruffy changed the title Fix broken Debian build badge in the README. Fix broken Debian CI test badge in the README. Mar 27, 2024
@fruffy
Copy link
Collaborator

fruffy commented Mar 27, 2024

I have updated the title to better reflect what the PR is actually doing. It is important to be precise to reduce cognitive load.

@fruffy fruffy changed the title Fix broken Debian CI test badge in the README. Fix broken Debian CI test badge in the README. Add Fedora and MacOS CI badge. Mar 27, 2024
@fruffy fruffy added this pull request to the merge queue Mar 27, 2024
Merged via the queue into p4lang:main with commit 0300f4a Mar 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants