Clean up P4Tools and control-plane linking. #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
enhancement
fruffy
force-pushed
the
fruffy/testgen_linking_fixes
branch
3 times, most recently
from
519271a
to
d9c6693
Compare
fruffy
force-pushed
the
fruffy/testgen_linking_fixes
branch
from
d9c6693
to
8bf36bd
Compare
asl
reviewed
Mar 15, 2024
| # TODO(https://github.com/p4lang/p4c/issues/4477): | ||
| # We should not need this, but because of the way managed includes and | ||
| # libraries for Protobuf we need to explicitly add the include directories here. | ||
| SYSTEM BEFORE PUBLIC ${Protobuf_INCLUDE_DIRS} |
There was a problem hiding this comment.
While we are here, maybe solve protobuf include madness? Can we just link protobuf as library?
There was a problem hiding this comment.
Since we pushed the minimum Protobuf version to 3.25 we should be able to clean this up yeah. Was planning on doing it once I have some more cycles.
asl
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we only export what is necessary and link most libraries privately. Also remove the
add_p4tools_libraryfunction, it is too inflexible andadd_libraryworks just fine.