-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Backend to directory structure #4503
[docs] Add Backend to directory structure #4503
Conversation
AdarshRawat1
commented
Mar 6, 2024
•
edited
Loading
edited
- Add Backend to directory
- Add Subdirectories of backends
Good catch this is incomplete.
How deep do you wish to go? The backends are very different and presumably it is quite rare for one person to actively work on many backends so having the documentation for each backend separately makes more sense to me. |
Thank you😁
Sure, I was also thinking that, adding the subdirectories in "Compiler source code organization" would make it too cluttered.
I initially thought it would be nice if I could cover all the subdirectories in "Compiler source code organization", but as you correctly pointed out that, it's more practical to have them covered in separate readme. What are your thoughts on this? |
Yes, that is the better approach. It will be difficult to maintain the tree for all possible back ends. The back ends are often maintained by independent teams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some suggestions on rewording.
Noted !! If this sounds right to you then, |
Thanks for your suggestions . |
[docs] Update description of "common" directory in "Compiler source code organization" Section Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
[docs] Update description of "dpdk" backend in "Compiler source code organization" Section Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Update description of "p4tools" , "tc" and "ubpf" directory in "Compiler source code organization" Section Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
Updated the PR based on suggestions.🚀 |
Please have a look at the "Backend source code organization" Section , does this look appropriate to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean up some small things then we are good to go.
Implemented Suggestions, renamed front end's description also. |
Please guide me on how this looks to you. Do we add this or not? |
I would discuss this in a separate PR. However, we do not need to know about every single compilation unit or header file. The folders are meant to give a broad overview over the content. |
Noted ! |