Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish runner OS. #4487

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Distinguish runner OS. #4487

merged 1 commit into from
Feb 29, 2024

Conversation

fruffy-g
Copy link
Contributor

No description provided.

@vlstill
Copy link
Contributor

vlstill commented Feb 29, 2024

Is this error related to this fix? https://github.com/p4lang/p4c/actions/runs/8100632186/job/22139073840

@asl
Copy link
Contributor

asl commented Feb 29, 2024

Is this error related to this fix? https://github.com/p4lang/p4c/actions/runs/8100632186/job/22139073840

Looks like this

@asl
Copy link
Contributor

asl commented Feb 29, 2024

Ah, wait, no:

Cache not found for input keys: macOS-82a99d9018fb2349f9a79c1ab6a3be43c0b098233089c427be095726369debdc

@fruffy
Copy link
Collaborator

fruffy commented Feb 29, 2024

Is this error related to this fix? https://github.com/p4lang/p4c/actions/runs/8100632186/job/22139073840

Yes, I am simply guessing it was a cache issue, although I thought runner.os would already distinguish them. If this does not work, I need to figure out why the M1 homebrew can not find that particular boost version all of a sudden. It seems supported:
https://formulae.brew.sh/formula/boost

@asl
Copy link
Contributor

asl commented Feb 29, 2024

Something wrong with cache paths:

Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

@asl
Copy link
Contributor

asl commented Feb 29, 2024

Yes, I am simply guessing it was a cache issue, although I thought runner.os would already distinguish them. If this does not work, I need to figure out why the M1 homebrew can not find that particular boost version all of a sudden. It seems supported:

Yes:

brew info boost
==> boost: stable 1.84.0 (bottled), HEAD
Collection of portable C++ source libraries
https://www.boost.org/
/opt/homebrew/Cellar/boost/1.83.0 (16,038 files, 508.4MB) *

@fruffy
Copy link
Collaborator

fruffy commented Feb 29, 2024

Yeah runner.os returns macOS here, so it must have been a cache conflict. I believe the cache paths are correct.

@fruffy fruffy added this pull request to the merge queue Feb 29, 2024
Merged via the queue into p4lang:main with commit f9c1f16 Feb 29, 2024
17 checks passed
@asl
Copy link
Contributor

asl commented Feb 29, 2024

@fruffy Does not seem to help. It looks like brew is already pre-installed in the image. Maybe we'd need to do brew update explicitly before installation.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants