Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Stop when an error is throwing in the P4Runtime serializer. Make stop-on-error explicit in the Midend class. #4408

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[P4Testgen] Stop when an error is throwing in the P4Runtime serializer. Make stop-on-error explicit in the Midend class. #4408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/p4tools/common/compiler/compiler_target.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ P4::FrontEnd CompilerTarget::mkFrontEnd() const { return {}; }
MidEnd CompilerTarget::mkMidEnd(const CompilerOptions &options) const {
MidEnd midEnd(options);
midEnd.addDefaultPasses();
midEnd.setStopOnError(true);
return midEnd;
}

Expand Down
4 changes: 4 additions & 0 deletions backends/p4tools/modules/testgen/targets/bmv2/bmv2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ CompilerResultOrError Bmv2V1ModelCompilerTarget::runCompilerImpl(
/// After the front end, get the P4Runtime API for the V1model architecture.
auto p4runtimeApi = P4::P4RuntimeSerializer::get()->generateP4Runtime(program, "v1model");

if (::errorCount() > 0) {
return std::nullopt;
}

program = runMidEnd(program);
if (program == nullptr) {
return std::nullopt;
Expand Down
Loading