[P4Testgen] Add a silent mode to P4Tools. Add performance counting at the top level. #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/metrics
branch
from
9982ea9
to
bcb8310
Compare
fruffy
force-pushed
the
fruffy/metrics
branch
from
bcb8310
to
0483c2b
Compare
fruffy
force-pushed
the
fruffy/testbackend_config
branch
from
709a48f
to
708dfa1
Compare
fruffy
force-pushed
the
fruffy/metrics
branch
from
0483c2b
to
01d49f7
Compare
fruffy
force-pushed
the
fruffy/testbackend_config
branch
4 times, most recently
from
d2a5bb4
to
5ac93fd
Compare
fruffy
force-pushed
the
fruffy/metrics
branch
from
01d49f7
to
02cd234
Compare
smolkaj
approved these changes
Feb 8, 2024
backends/p4tools/common/options.cpp
Outdated
| @@ -181,6 +181,14 @@ AbstractP4cToolOptions::AbstractP4cToolOptions(cstring message) : Options(messag | |||
| }, | |||
| "Provides a randomization seed"); | |||
|
|
|||
| registerOption( | |||
| "--disable-info", nullptr, | |||
There was a problem hiding this comment.
Would it make sense to include the keyword "log" or "logging" in the name of the flag somehow?
fruffy
force-pushed
the
fruffy/testbackend_config
branch
from
5ac93fd
to
81974aa
Compare
fruffy
force-pushed
the
fruffy/metrics
branch
from
02cd234
to
c623011
Compare
fruffy
force-pushed
the
fruffy/testbackend_config
branch
2 times, most recently
from
fd7c6d7
to
a50b982
Compare
fruffy
force-pushed
the
fruffy/metrics
branch
from
c623011
to
44b677b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to disable printing any information to standard output. This does not disable warnings, errors, or outputs which may be enabled by other options.
Also add a timer to the top-level and print metrics there for better collection of statics.