Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eBPF section names for tc backend #4361

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

vbnogueira
Copy link
Contributor

Rename parser C file's eBPF section to "p4tc/parse" and control blocks C file's eBPF section to "p4tc/main".

Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@usha1830
Copy link
Contributor

usha1830 commented Feb 5, 2024

@vbnogueira some reference outputs need to be updated. Please check.

@vbnogueira
Copy link
Contributor Author

@vbnogueira some reference outputs need to be updated. Please check.

Rebased, regenerated and pushed

@vbnogueira
Copy link
Contributor Author

Seems like the tests are failing because of a problem with apt-get in ubuntu:

44.89 + add-apt-repository -uy ppa:ubuntu-toolchain-r/test
75.83 Error: retrieving gpg key timed out.

Seems like an internal issue.
Is there a way to try and make it run again after this is solved?

@fruffy fruffy added the p4tc Topics related to the P4-TC back end label Feb 5, 2024
@usha1830
Copy link
Contributor

usha1830 commented Feb 7, 2024

Seems like the tests are failing because of a problem with apt-get in ubuntu:

44.89 + add-apt-repository -uy ppa:ubuntu-toolchain-r/test
75.83 Error: retrieving gpg key timed out.

Seems like an internal issue. Is there a way to try and make it run again after this is solved?

The tests are passing, but branch needs rebase with main before we could merge this.

Rename parser C file's eBPF section to "p4tc/parse" and control blocks C
file's eBPF section to "p4tc/main".
@usha1830 usha1830 enabled auto-merge (squash) February 7, 2024 06:52
@usha1830 usha1830 merged commit 6cec6b4 into p4lang:main Feb 7, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tc Topics related to the P4-TC back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants