Improve diagnostics for AssignmentStatement
#4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
approved these changes
Jan 25, 2024
jafingerhut
approved these changes
Jan 25, 2024
auto-merge was automatically disabled
January 25, 2024 21:31
Head branch was pushed to by a user without write access
kfcripps
force-pushed
the
improve-diagnostics-assignmentstmt
branch
from
ed11500
to
b9228ab
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I surrounded several places that can print
AssignmentStatements with '', but now other types of nodes get surrounded with '' when they don't necessarily need to be. @fruffy Let me know if you prefer it this way or without quotes in these places.