Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected contents of p4info files. #4356

Closed
wants to merge 1 commit into from

Conversation

kfcripps
Copy link
Contributor

This is what I get when I run P4TEST_REPLACE=1 make check on main ToT.

@fruffy
Copy link
Collaborator

fruffy commented Jan 24, 2024

Can you rebase and check whether this still applies?

@kfcripps
Copy link
Contributor Author

@fruffy Sure, is #4348 expected to fix this?

@fruffy
Copy link
Collaborator

fruffy commented Jan 24, 2024

@fruffy Sure, is #4348 expected to fix this?

No, was thinking there was a mismatch with #4350. But that does not seem to be the case. In either case, in order to merge this PR it needs to up-to-date with main.

@kfcripps
Copy link
Contributor Author

Ok, I will rebase after checking that the CI passes.

@fruffy
Copy link
Collaborator

fruffy commented Jan 24, 2024

#4352, which is approved should also fix this. But we can merge yours first to unblock you.

@kfcripps
Copy link
Contributor Author

@fruffy If you think that #4352 will be merged today, then I can wait and I'll close this.

@kfcripps
Copy link
Contributor Author

Do any of the jobs spuriously fail? I noticed that the CI was red earlier, and now it is yellow, so I'm assuming that either someone re-triggered the failing job or it was re-triggered automatically, and I'm wondering if it is the same job that is currently failing in #4357.

@kfcripps
Copy link
Contributor Author

Ah, looks like it failed again here

@fruffy
Copy link
Collaborator

fruffy commented Jan 24, 2024

This has been recently, unclear what changed to cause this failure. A fix might be to increase the waiting time in the PTF tests.

@fruffy
Copy link
Collaborator

fruffy commented Jan 24, 2024

I merged #4352, which should make this PR obsolete.

@kfcripps
Copy link
Contributor Author

Thank you @fruffy

@kfcripps kfcripps closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants