DoConstantFolding: make typeMap param const #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
approved these changes
Jan 22, 2024
grg
force-pushed
the
grgibb/constant_folding_missing_const
branch
from
38f65f1
to
e8ae05c
Compare
vlstill
approved these changes
Jan 23, 2024
The DoConstantFolding constructor takes a `TypeMap` parameter (typeMap) and stores it in a `const TypeMap` variable. Add the `const` keyword for the parameter. (It does not need to be non-const.)
grg
force-pushed
the
grgibb/constant_folding_missing_const
branch
from
e8ae05c
to
10a5257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DoConstantFolding constructor takes a
TypeMapparameter (typeMap) and stores it in aconst TypeMapvariable. Add theconstkeyword for the parameter. (It does not need to be non-const.)