Update gRPC python version in install_fedora_deps.sh #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
force-pushed
the
fix-fedora-ci-build
branch
2 times, most recently
from
15fafc1
to
32b026b
Compare
|
This will unstuck pending PRs which have received approval |
mihaibudiu
approved these changes
Nov 10, 2023
rst0git
approved these changes
Nov 10, 2023
jafingerhut
approved these changes
Nov 10, 2023
The fedora:latest container now comes with Python 3.12. Older gRPC versions do not support this Python version. See grpc/grpc#33063. An alternative would be to pin the fedora container version, but then someone has to remember to update it periodically... Signed-off-by: Antonin Bas <antonin.bas@gmail.com>
Required for more recent versions of Python3 Signed-off-by: Antonin Bas <antonin.bas@gmail.com>
antoninbas
force-pushed
the
fix-fedora-ci-build
branch
from
3b274cf
to
00af910
Compare
Yes, I'm on commit 3 now. I'm moving from issue to issue, all because of a more recent Python version. But hopefully, the 3rd issue was the last one. |
Changed in Python version 3.12: mkdtemp() now always returns an absolute path, even if dir is relative. Signed-off-by: Antonin Bas <antonin.bas@gmail.com>
antoninbas
force-pushed
the
fix-fedora-ci-build
branch
from
00af910
to
e292b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fedora:latest container now comes with Python 3.12. Older gRPC versions do not support this Python version. See
grpc/grpc#33063.
An alternative would be to pin the fedora container version, but then someone has to remember to update it periodically...