Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved bootstrap.sh #4227

Merged
merged 1 commit into from
Nov 7, 2023
Merged

improved bootstrap.sh #4227

merged 1 commit into from
Nov 7, 2023

Conversation

ChrisDodd
Copy link
Contributor

No description provided.

ln -sf "$(realpath --relative-to "${link_name_dir}/" "${target}")" "${link_name}"
}

make_relative_link "${mydir}/.gdbinit" "backends/bmv2/p4c-bm2-psa-gdb.gdb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is something to instantiate within CMakelists for each back end instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a way to do it in cmake, maybe. I've had little luck with getting cmake to set up things like this, and it is not strictly needed for the build. Just nice to have if you run gdb

@fruffy
Copy link
Collaborator

fruffy commented Nov 6, 2023

The MacOS test is failing because of a substitution issue.

@ChrisDodd
Copy link
Contributor Author

The MacOS test is failing because of a substitution issue.

Ugh -- I guess MacOS's bash is not really bash? They don't like GPL'd things.

@ChrisDodd
Copy link
Contributor Author

There seem to be some intermittent failures in the dpdk CI tests that this change is running into.

@fruffy
Copy link
Collaborator

fruffy commented Nov 7, 2023

There seem to be some intermittent failures in the dpdk CI tests that this change is running into.

Yes, unfortunately the P4-DPDK target is not stable. Trying to disable the tests here: #4228.

@ChrisDodd ChrisDodd merged commit ac40e1f into main Nov 7, 2023
14 checks passed
@ChrisDodd ChrisDodd deleted the cdodd-options branch November 7, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants