Set headers valid when expanding initializations #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
approved these changes
May 26, 2020
| @@ -77,6 +77,7 @@ parser ParserImpl(packet_in packet, out headers hdr, inout metadata meta, inout | |||
| @name(".parse_ipv4") state parse_ipv4 { | |||
| tmp = packet.lookahead<bit<160>>(); | |||
| tmp_hdr_0.setValid(); | |||
| tmp_hdr_0.setValid(); | |||
There was a problem hiding this comment.
So it looks like we get redundant setValid calls in some cases? Harmless, but do we know why this happens?
There was a problem hiding this comment.
I guess this happens if the user was already setting the header to valid before assigning to it.
We should write an analysis which can remove the useless setValid; it could probably be folded in the def-use analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2383