Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Autoassigned] Fix the text alignment #99

Open
p4535992 opened this issue Sep 6, 2024 · 3 comments
Open

[BUG][Autoassigned] Fix the text alignment #99

p4535992 opened this issue Sep 6, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed patched

Comments

@p4535992
Copy link
Owner

p4535992 commented Sep 6, 2024

Module Version: v1.10.5

For "patch" this a module setting called "Trick Setting: Enter the number of white spaces to be added as suffix (or prefix with negative number) in the nameplate of the note for a better center alignment" was created...

It was a horrible solution-which I wish I could solve.

It was a horrible solution ... that I wish I could fix and remove that setting for everybody's sanity.

image-4

You can ignore the yellow banner is just the custom image associated with the note, for ticket #99, the problem is derived from the module setting “Width size to ratio” which basically “forces” a width for the note, but I would like that when the width of the note image is set by retrieving the X,Y coordinates of the “damped” image, there is a way to align the text with it. The module setting “Trick Setting: Enter the number of white spaces to be added as suffix (or prefix with negative number)” I created it because I couldn't do the math of the calculation, it was a solution that worked for v11 , but I was told by a third party that in v12 it doesn't work as before, I haven't tested it personally because I lack the time, but there is also that by solving the first issue #97 maybe you solved #99 as well. To understand each other the “automatic” math would be appreciated, but if the old “Trick Setting: Enter the number of white spaces to be added as suffix (or prefix with negative number)” would also come back to work, that would be acceptable.

@p4535992 p4535992 added bug Something isn't working help wanted Extra attention is needed labels Sep 6, 2024
LeRatierBretonnien added a commit to LeRatierBretonnien/foundryvtt-pin-cushion that referenced this issue Sep 8, 2024
p4535992 added a commit that referenced this issue Sep 9, 2024
@Zarhog
Copy link

Zarhog commented Sep 10, 2024

image
Latest updated seem to have broken this further.

the Align Text on the page one of the settings, seems to be defualting to "Right" reguardless of what is slected

@CliseAndTyl
Copy link

I can confirm that I am also seeing this bug after recently updating
misalignment

@p4535992
Copy link
Owner Author

Patched by adding some extra settings to maually adjust this. The issue will remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed patched
Projects
None yet
Development

No branches or pull requests

3 participants