-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no response on Serial* with high BAUDRATE #47
Conversation
Fix no response on Serial* for LPC1768 (SKR v1.3) with BAUDRATE > 250000 Fix no response on Serial* for LPC1769 (SKR v1.4 Turbo) with BAUDRATE >= 1000000 Fix derived from MarlinFirmware/Marlin#22284 that was tested on Marlin with SERIAL_PORT 0 on SKR v1.3 and with SERIAL_PORT 0, 1, 3 on SKR v1.4 Turbo . With that fix verified 57600, 115200, 250000, 460800, 500000, 921600, 1000000 BAUDRATEs work.
@p3p Note this patch is untested as I don't know the magic platformio incantation for platform and platform_packages to redirect it my local git repo or https://github.com/mihai-dumitresq/pio-framework-arduino-lpc176x/tree/patch-1 |
Hey thanks for finding this, I think you can use this syntax: |
First try,
At least the error is self explanatory. Second try, switch default branch and
Not sure what I was expecting. There's no third try as "just checkout my repository into platformios packages folder" is exactly what the
But on the seventh try, when I hackily set Tested (less exhaustively) this pull request works: Pull request ready to merge. |
PlatformIO must change the version string from .. well the version .. when you use a git link, my little hack to expose the framework version as a global define (so Marlin can see it) can't handle non numerics. If you used the zip Anyway thanks for testing, its a simple change I don't see any possible side effects so I don't see a problem merging .. although I've said that before and come to regret it ^^. |
The
It's a very small change and I've manually tested it. It'll be fine :) |
Thank you! |
Fix no response on Serial* for LPC1768 (SKR v1.3) with
BAUDRATE
> 250000Fix no response on Serial* for LPC1769 (SKR v1.4 Turbo) with
BAUDRATE
>= 1000000Fix derived from MarlinFirmware/Marlin#22284 that was tested on Marlin with
SERIAL_PORT
0 on SKR v1.3 and withSERIAL_PORT
0, 1, 3 on SKR v1.4 Turbo . With that fix verified 57600, 115200, 250000, 460800, 500000, 921600, 1000000BAUDRATE
s work.