Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH-1068 - send fees fix #2216

Merged
merged 3 commits into from
Feb 26, 2024
Merged

ETH-1068 - send fees fix #2216

merged 3 commits into from
Feb 26, 2024

Conversation

eduardmaximovich
Copy link
Collaborator

Jira Ticket

https://p2pvalidator.atlassian.net/browse/

Description of Work

  • get all fees from send-service, including use-max case
  • new crutches

@eduardmaximovich eduardmaximovich self-assigned this Feb 26, 2024
@github-actions GitHub Actions
Copy link

Code coverage report

File Coverage [66.67%] Min. Covered
SendFeeRelayerManager.kt 0.00% 💩
SendServiceApi.kt 0.00% 💩
FeePayersRepository.kt 0.00% 💩
SendInteractor.kt 0.00% 💩
CalculateSendFeesUseCase.kt 0.00% 💩
SendServiceFees.kt 0.00% 💩
GeneratedTransaction.kt 0.00% 💩
SendServiceRemoteRepository.kt 0.00% 💩
SendServiceRepository.kt 0.00% 💩
NewSendPresenter.kt 0.00% 💩
NewSendDetailsPresenter.kt 0.00% 💩
Total Project Coverage 4.56% 💩

@eduardmaximovich eduardmaximovich merged commit ddf90ad into develop Feb 26, 2024
4 checks passed
@eduardmaximovich eduardmaximovich deleted the feature/ETH-1068-send-fees-overhaul branch February 26, 2024 15:13
eduardmaximovich added a commit that referenced this pull request Feb 26, 2024
@eduardmaximovich
ETH-1068 - send fees fix (#2216)
d302363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gslevinkov gslevinkov gslevinkov approved these changes

Assignees

@eduardmaximovich eduardmaximovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardmaximovich @gslevinkov