Handle np.datetime64
and other numpy dtypes with odd subclasses/constructors
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #46
np.datetime64
isn't a dtype class like other dtypes, it produces a different type:But the
type
attribute is unambiguous:This is similar to numpy string dtypes.
Fix is simple and generic - just check the
type
attribute if it's present.opening first with failing test, then with fix