Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loom batch rendering dont work with placeholders option? #45

Closed
Chrisyahya opened this issue Feb 14, 2023 · 6 comments
Closed

loom batch rendering dont work with placeholders option? #45

Chrisyahya opened this issue Feb 14, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Chrisyahya
Copy link

Hello. I love your addon, it helps me alot. But there is one thing : i run 2 computers rendering on same animation. Usually i use overwrite disabled and placeholder enabled.

Place holders will make an empty file frame, while being rendered so other computer will skip that frame (so wont make 2 computers working on same frame).

but loom batch rendering apparently dont make placeholders, so it could end up rendering on same frames. Or maybe i misconfigured? thank you!

p2or added a commit that referenced this issue Feb 14, 2023
@p2or
Copy link
Owner

p2or commented Feb 14, 2023

Hi @Chrisyahya,

thanks for your report. This should work out of the box if 'Overwrite' is disabled and the file exists on disk, make sure the file path is correct. However, while testing I noticed a tiny little inconsistency for batch rendering and created a new branch to address this. I am not sure whether this is your issue though.

Should help in any case, because every skipped frame is now reported in the terminal:

Screenshot 2023-02-14 at 08 52 17

If you have the time, please download Loom from there using the download button and report back. If that does not solve your issue, please provide a simple file to test against, thanks.

Cheers,
Christian

@p2or p2or added the question Further information is requested label Feb 14, 2023
@p2or
Copy link
Owner

p2or commented Feb 15, 2023

Hi @Chrisyahya,

had some time to investigate... You're absolutely right, Blender does not write the placeholders in this case. I guess because we are rendering single images with Loom.

I revisited the code in the other branch to write custom placeholders, should now work as expected. If you have the time, please download Loom from there using the download button and report back.

Good catch,
Christian

@p2or p2or added enhancement New feature or request and removed question Further information is requested labels Feb 15, 2023
@Chrisyahya
Copy link
Author

@p2or hello! I tried the placeholder addon version and it worked as i intend. Thank you!
just a very minor caveat when i cancelled the rendering prematurely, the placeholder still exists, and when retry render, it skipped the placeholder images.
But, it's alright! the original blender renderer also doing this, i'll delete the place holder manually.

skipping frame text in CLI is nice addition though, so i could track is it skipping correctly.

@p2or
Copy link
Owner

p2or commented Feb 16, 2023

Hi @Chrisyahya,

great, thanks for testing. Since you can kill the terminal at any time, I see no way to remove the non-rendered placeholder at some point. We could check the image size before rendering, but that might be overkill and could affect the overall computation time, I guess. As you mentioned, it shouldn't take too long to sort the images by size in the file browser and then simply delete those with a size of 0kb manually before rendering. Anyway, if you have another or even better idea for this, please let me know. I'm glad it's working now.

Cheers,
Christian

@Chrisyahya
Copy link
Author

Update : Loom sometimes skipped place holders.

Weird. it's like, the loom working on frame 100. the it done rendering frame 100, going to 101, and suddenly loom after creating placeholder of frame 101, it would go to 102 and rendering. So it make few frames 0Kb data. Happens at random event.

@p2or
Copy link
Owner

p2or commented Mar 25, 2023

Hi @Chrisyahya,

interesting, difficult to reproduce though. Could you please provide a minified blend-file for debugging?

Thanks,
Christian

@p2or p2or closed this as completed in 5c19923 Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants