Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: dockerized piper #93

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

allen-n
Copy link
Contributor

@allen-n allen-n commented Nov 14, 2024

Adds a docker-compose config that simplifies using piper locally - though it does require the piper voice to be set in the docker compose yml, rather than as a command line argument.

Two usage modes exist: Passing the full set of command line args in the compose file (including the new piper_docker tts engine), or running the container in interactive mode and calling main.py from there. Both are detailed in the docker-compose.piper-example.yml.

The clear benefit here is easy-mode usage of piper, regardless of machine. All that's required is cloning the repo, configuring the docker compose depending on which of the two options above is better suited for your use case, and running docker compose up. Can confirm this works on an M1 Macbook Pro with no compatibility issues etc.

…semaphore based locking to limit local concurrency
@allen-n allen-n force-pushed the allen-n/dockerized-piper branch from 631d96a to c63cbd4 Compare November 14, 2024 19:24
…xample docker compose file

Remove unused import
@allen-n allen-n force-pushed the allen-n/dockerized-piper branch from c63cbd4 to a1745ad Compare November 14, 2024 19:26
@p0n1
Copy link
Owner

p0n1 commented Dec 12, 2024

Thanks for your awesome contributing. I'm about to merge this PR.

Would be nice if you can update README and add very simple guidance to instruct users to use piper_docker just bellow the https://github.com/p0n1/epub_to_audiobook?tab=readme-ov-file#examples-using-piper-tts section.

@allen-n
Copy link
Contributor Author

allen-n commented Dec 12, 2024

@p0n1 of course! Thanks for doing all the heavy lifting to get this built. Just went ahead and added fairly explicit instructions to the readme on how to use.

@p0n1
Copy link
Owner

p0n1 commented Dec 13, 2024

Nice. LGTM. Thanks again.

@p0n1 p0n1 merged commit 56b0c57 into p0n1:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants