Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add german translations to the editor #56

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

halykon
Copy link
Contributor

@halykon halykon commented Jul 17, 2023

This pull request introduces translations for the German locale to Verbum, further expanding internationalization and user accessibility.

Here are the primary changes introduced in this PR:

  • German Translation Files: Added .json translation files for German locale under the locale/languagesdirectory.
  • Updated the index.tsx inside of locale/languages to import the new translations and provide it as values for the de key in the already existing resources dictionary.

Testing:
I tested everything on my local device and everything seems fine, however there are no automated tests to run so you'll have to trust me on this one.

Request for Review:

I kindly request the maintainers and community members to review these changes. Any feedback or suggestions for improvement are welcome.

@ozanyurtsever ozanyurtsever requested a review from DiggesT October 2, 2023 11:33
@ozanyurtsever
Copy link
Owner

@DiggesT Is it possible for you to review this one and test it?

@DiggesT
Copy link
Collaborator

DiggesT commented Oct 2, 2023

Yes, I'll do it later.

@ozanyurtsever ozanyurtsever merged commit 766b3f3 into ozanyurtsever:master Mar 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants